Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Tsubo, a Japanese unit of floorspace for Japan and Taiwan #2101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TobySkarting
Copy link

Fixes #2100.

Description of the changes:

  • Added JP & TW to the existing Tsubo-equivalent unit conversion Pyeong.

How changes were validated:

  • User can convert between Tsubo and other units of area (such as square meters, square feet, etc.) within the Calculator app.
    image

@DandelionSprout
Copy link

DandelionSprout commented Feb 17, 2024

As someone with no affiliation to this repo at all, I honestly find it odd that both this and to some extent #382 limit the measurement to a select few locales only. I'd have been very glad to have the measurements being extended to en-GB, en-US, nb-NO, de-DE, and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding support for Tsubo (坪), a Japanese unit of floorspace for Japan and Taiwan
3 participants