Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fluent Design guidelines link to latest version #2216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JuanFKurucz
Copy link

Description of the changes:

I found that the design guidelines link is broken as the fluent design was updated to version two, i changed the link to the new version.

@ghost
Copy link

ghost commented Aug 9, 2024

I believe there is some confusion here.

  1. The original link (https://developer.microsoft.com/en-us/windows/apps/design) refers to the Fluent Design for Windows Apps documentation page, with several example screenshots and XAML code.

  2. The new link you suggest changing (https://fluent2.microsoft.design/) refers to the Fluent Design version two principles page (not necessarily for Windows Apps), without any XAML code examples.

For reference purposes, the link for Fluent Design version one principles page is (https://fluent1.microsoft.design/). Note that the code never referenced version one of the principles, but rather the documentation, so I believe it would be a mistake to change it to the link for version two of the principles.

Maybe I'm wrong. Let's see if this PR will be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant