Skip to content

Commit

Permalink
PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
crickman committed Nov 8, 2023
1 parent 4e641de commit 244a45b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion webapi/Controllers/ChatController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ await planner.Kernel.ImportPluginFunctionsAsync(
if (openApiSkillsAuthHeaders.TryGetValue("JIRA", out string? JiraAuthHeader))
{
this._logger.LogInformation("Registering Jira plugin");
var authenticationProvider = new BearerAuthenticationProvider(() => { return Task.FromResult(JiraAuthHeader); });
var authenticationProvider = new BasicAuthenticationProvider(() => { return Task.FromResult(JiraAuthHeader); });
var hasServerUrlOverride = variables.TryGetValue("jira-server-url", out string? serverUrlOverride);

await planner.Kernel.ImportPluginFunctionsAsync(
Expand Down
2 changes: 1 addition & 1 deletion webapi/Services/SemanticKernelProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ IMemoryStore CreateMemoryStore()
var qdrantConfig = memoryOptions.GetServiceConfig<QdrantConfig>(configuration, "Qdrant");

#pragma warning disable CA2000 // Ownership passed to QdrantMemoryStore
HttpClient httpClient = new(new HttpClientHandler { CheckCertificateRevocationList = true }); // $$$
HttpClient httpClient = new(new HttpClientHandler { CheckCertificateRevocationList = true });
#pragma warning restore CA2000 // Ownership passed to QdrantMemoryStore
if (!string.IsNullOrWhiteSpace(qdrantConfig.APIKey))
{
Expand Down

0 comments on commit 244a45b

Please sign in to comment.