Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Chat-Copilot to SemanticKernel Beta 7 #615

Closed
wants to merge 4 commits into from
Closed

Update Chat-Copilot to SemanticKernel Beta 7 #615

wants to merge 4 commits into from

Conversation

crickman
Copy link
Contributor

@crickman crickman commented Nov 16, 2023 •
edited
Loading

Motivation and Context

Stay in sync with the "latest and greatest"!

VERIFIED

Description

https://github.com/microsoft/semantic-kernel/pkgs/nuget/Microsoft.SemanticKernel.Core/148204203

image image

Contribution Checklist

@crickman crickman self-assigned this Nov 16, 2023
@github-actions github-actions bot added the webapi Pull requests that update .net code label Nov 16, 2023
@crickman crickman added enhancement New feature or request memory Issues or questions related to memory labels Nov 16, 2023
@crickman
Copy link
Contributor Author

crickman commented Nov 16, 2023 •
edited
Loading

Waiting for kernel-memory nuget update (currently this PR is draft)

@crickman crickman marked this pull request as ready for review November 16, 2023 19:24
@crickman crickman enabled auto-merge November 16, 2023 19:26
glahaye
glahaye previously approved these changes Nov 16, 2023
View reviewed changes
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 16, 2023
@crickman crickman requested a review from glahaye November 16, 2023 19:43
@crickman
Copy link
Contributor Author

Some OpenAI links shifted...the "Models" one may be problematic.

glahaye
glahaye previously approved these changes Nov 16, 2023
View reviewed changes
@momuno
Copy link
Member

momuno commented Nov 16, 2023

@crickman I'm seeing the same issues with platform.openai.com markdown link check. the 3 links getting 403 are valid.

@crickman crickman requested a review from glahaye November 16, 2023 23:11
@github-actions github-actions bot added the webapp Pull requests that update Typescript code label Nov 16, 2023
momuno
momuno suggested changes Nov 18, 2023
View reviewed changes
Copy link
Member

@momuno momuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this was tested for plugin functionality in CC and does not work. Let's get that issue figured out and then we can merge this :)

@momuno
Copy link
Member

momuno commented Nov 20, 2023

Replaced with #615

@momuno momuno closed this Nov 20, 2023
auto-merge was automatically disabled November 20, 2023 18:22

Pull request was closed

@glahaye
Copy link
Contributor

glahaye commented Nov 20, 2023

You mean #626

@momuno
Copy link
Member

momuno commented Nov 20, 2023

You mean #626

yes! this is what happens when you work while being sick lol

@glahaye glahaye deleted the update_sk_beta7 branch November 23, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momuno momuno momuno requested changes

@glahaye glahaye glahaye approved these changes

@alliscode alliscode Awaiting requested review from alliscode

Assignees

@crickman crickman

Labels
documentation Improvements or additions to documentation enhancement New feature or request memory Issues or questions related to memory webapi Pull requests that update .net code webapp Pull requests that update Typescript code
Projects
No open projects
Apps & Services Semantic Kernel
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crickman @momuno @glahaye