Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@alvesfabi OBO Support #803

Merged
merged 76 commits into from
May 15, 2024
Merged

@alvesfabi OBO Support #803

merged 76 commits into from
May 15, 2024

Conversation

teresaqhoang
Copy link
Contributor

Motivation and Context

@alvesfabi's work to implement the OBO flow for OpenAI Plugin Specs

Description

Contribution Checklist

@teresaqhoang teresaqhoang self-assigned this Feb 15, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file webapp Pull requests that update Typescript code webapi Pull requests that update .net code labels Feb 15, 2024
.vscode/launch.json Outdated Show resolved Hide resolved
chat azure open ai dev settings.txt Outdated Show resolved Hide resolved
webapi/Controllers/ChatController.cs Outdated Show resolved Hide resolved
webapi/Plugins/Chat/ApiConnectorPlugin.cs Outdated Show resolved Hide resolved
webapi/Plugins/Chat/ApiConnectorPlugin.cs Outdated Show resolved Hide resolved
webapi/Plugins/Chat/ApiConnectorPlugin.cs Outdated Show resolved Hide resolved
webapp/src/Constants.ts Outdated Show resolved Hide resolved
webapp/tsconfig.json Outdated Show resolved Hide resolved
@teresaqhoang teresaqhoang marked this pull request as ready for review May 9, 2024 18:27
@teresaqhoang teresaqhoang requested a review from alvesfabi May 9, 2024 18:27
alliscode
alliscode previously approved these changes May 10, 2024
plugins/OBO/README.md Outdated Show resolved Hide resolved
webapi/Controllers/ChatController.cs Outdated Show resolved Hide resolved
webapi/Plugins/Chat/ChatPlugin.cs Outdated Show resolved Hide resolved
webapi/Plugins/Chat/MsGraphOboPlugin.cs Show resolved Hide resolved
webapi/Plugins/Utils/JsonUtils.cs Outdated Show resolved Hide resolved
Co-authored-by: Tao Chen <taochen@microsoft.com>
Co-authored-by: Tao Chen <taochen@microsoft.com>
Copy link
Contributor

@alvesfabi alvesfabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed merge error - added comment for msal setup change in index.ts

@teresaqhoang teresaqhoang requested a review from alvesfabi May 15, 2024 12:13
@teresaqhoang teresaqhoang enabled auto-merge May 15, 2024 15:00
@teresaqhoang teresaqhoang added this pull request to the merge queue May 15, 2024
Merged via the queue into microsoft:main with commit d79f076 May 15, 2024
9 checks passed
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

@alvesfabi's work to implement the OBO flow for OpenAI Plugin Specs

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Fabian Alves <falves@microsoft.com>
Co-authored-by: Fabian Alves <50325768+alvesfabi@users.noreply.github.com>
Co-authored-by: Tao Chen <taochen@microsoft.com>
kb0039 pushed a commit to aaronba/chat-copilot that referenced this pull request Jan 8, 2025
### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

@alvesfabi's work to implement the OBO flow for OpenAI Plugin Specs

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄

---------

Co-authored-by: Fabian Alves <falves@microsoft.com>
Co-authored-by: Fabian Alves <50325768+alvesfabi@users.noreply.github.com>
Co-authored-by: Tao Chen <taochen@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation PR: paused For PRs that have been converted to draft, are facing blockers or have no active development planned webapi Pull requests that update .net code webapp Pull requests that update Typescript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants