Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Semantic Kernel 1.4 #817

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Upgrade to Semantic Kernel 1.4 #817

merged 7 commits into from
Feb 27, 2024

Conversation

glahaye
Copy link
Contributor

@glahaye glahaye commented Feb 23, 2024

Motivation and Context

Chat Copilot hasn't been upgraded to SK 1 and this hampers development.

Description

Upgrade to SK 1.4. It has OpenAI's function calling working but, other than that, no planning functionality.

Decision to remove planners:

  • The old action, sequential and stepwise planners are deprecated
  • The function-calling capabilities baked in OpenAI obsoleted most of their use
  • The code required to support planners as that functionality existed vastly needed to be re-written
  • Instead of re-writing that code and then finally merging the upgrade to main, the code was removed so that those not requiring planning could move on to the latest version of SK while those depending on planning can stay on the older CC version until planners are added back in (if this is eventually done - depending on demand and the amount of work we want to put in supporting CC)

Contribution Checklist

@github-actions github-actions bot added documentation Improvements or additions to documentation webapp Pull requests that update Typescript code webapi Pull requests that update .net code deployment Issues related to deploying Chat-Copilot labels Feb 23, 2024
@glahaye glahaye self-assigned this Feb 23, 2024
@glahaye glahaye marked this pull request as draft February 23, 2024 04:44
@glahaye glahaye mentioned this pull request Feb 23, 2024
4 tasks
@ezar
Copy link

ezar commented Feb 23, 2024

Thanks!!!

@ezar
Copy link

ezar commented Feb 23, 2024

Do you remove planner's kernel?

@glahaye
Copy link
Contributor Author

glahaye commented Feb 24, 2024

Do you remove planner's kernel?

Yes. The idea is that OpenAI's function-calling can figure out when to call functions without requiring a plan to do so.

Let me know if you think the lack of explicit planner will be a problem.

@ezar
Copy link

ezar commented Feb 24, 2024

@glahaye I have tried to use the Karna and Websercher plugins, but since the plan does not activate, they do not launch these and OpenAI responds directly. Is this the expected workflow?

I had to correct some exceptions that were thrown when trying to use the chat. For example, the duplication of the chatid in the list. Resolved using last commit.

Thank you very much because thanks to this project I can understand much more about the functioning of SK.

@glahaye
Copy link
Contributor Author

glahaye commented Feb 26, 2024

@glahaye I have tried to use the Karna and Websercher plugins, but since the plan does not activate, they do not launch these and OpenAI responds directly. Is this the expected workflow?

I am trying to fix the automatic function-calling today. When it works, plugins should automatically be invoked when they are relevant.

I had to correct some exceptions that were thrown when trying to use the chat. For example, the duplication of the chatid in the list. Resolved using last commit.

If you encounter problems, please feel free to enter them in this PR so that I can address them.

Thank you very much because thanks to this project I can understand much more about the functioning of SK.

My pleasure!

@glahaye glahaye marked this pull request as ready for review February 26, 2024 22:39
crickman
crickman previously approved these changes Feb 27, 2024
crickman
crickman previously approved these changes Feb 27, 2024
@glahaye glahaye added this pull request to the merge queue Feb 27, 2024
Merged via the queue into microsoft:main with commit 8da61c2 Feb 27, 2024
9 checks passed
@ezar
Copy link

ezar commented Feb 29, 2024

@glahaye I have tried to use the Karna and Websercher plugins, but since the plan does not activate, they do not launch these and OpenAI responds directly. Is this the expected workflow?

I am trying to fix the automatic function-calling today. When it works, plugins should automatically be invoked when they are relevant.

I am trying to use the websearcher plugin that has the solution, but it seems that it is not able to invoke it. Before migrating to SK 1.4 using the planner, I made the request.
I have tried using the Klarna plugin and it seems to work.

@glahaye glahaye deleted the upgrade_to_sk14 branch March 1, 2024 00:06
@glahaye
Copy link
Contributor Author

glahaye commented Mar 3, 2024

@ezar I'll see what I can do about the websearcher plugin. I'm not officially given any time for this project anymore so it might take a bit :/

teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
### Motivation and Context
Chat Copilot hasn't been upgraded to SK 1 and this hampers development.

### Description
Upgrade to SK 1.4

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
kb0039 pushed a commit to aaronba/chat-copilot that referenced this pull request Jan 8, 2025
### Motivation and Context
Chat Copilot hasn't been upgraded to SK 1 and this hampers development.

### Description
Upgrade to SK 1.4

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment Issues related to deploying Chat-Copilot documentation Improvements or additions to documentation webapi Pull requests that update .net code webapp Pull requests that update Typescript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants