Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align detection args between snapshot publish and verify #1294

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

FernandoRojo
Copy link
Contributor

Aligning the detection run args to make sure verification matches the published snapshot

@FernandoRojo FernandoRojo requested a review from a team as a code owner October 29, 2024 19:25
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.3%. Comparing base (9f24dfc) to head (0d5592c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1294   +/-   ##
=====================================
  Coverage   89.3%   89.3%           
=====================================
  Files        387     387           
  Lines      30372   30372           
  Branches    1868    1868           
=====================================
+ Hits       27147   27148    +1     
  Misses      2827    2827           
+ Partials     398     397    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 2, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@grvillic grvillic merged commit 69c5aaa into main Dec 4, 2024
22 of 25 checks passed
@grvillic grvillic deleted the users/ferojo/alignVerification branch December 4, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants