Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unauthorized files / dirs for cleanup #1328

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pauld-msft
Copy link
Member

Issue reported by customer. Agents that do not even have read access to some parts of the file system can run into issues when trying to determine the files and directories that need to be cleaned up.

Fix: error handle the unauthorized exception, and skip cleanup for those cases

@pauld-msft pauld-msft requested a review from a team as a code owner December 18, 2024 15:11
@pauld-msft pauld-msft requested a review from cobya December 18, 2024 15:11
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 81.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 89.7%. Comparing base (8a744bf) to head (a1459bc).

Files with missing lines Patch % Lines
...tion.Contracts/FileComponentDetectorWithCleanup.cs 69.5% 11 Missing and 3 partials ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1328   +/-   ##
=====================================
  Coverage   89.7%   89.7%           
=====================================
  Files        387     387           
  Lines      30272   30305   +33     
  Branches    1871    1871           
=====================================
+ Hits       27161   27191   +30     
- Misses      2713    2715    +2     
- Partials     398     399    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants