Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not register local and link components in pnpm9 detector #1331

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

FernandoRojo
Copy link
Contributor

No description provided.

@FernandoRojo FernandoRojo requested a review from a team as a code owner December 19, 2024 23:03
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 99.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.7%. Comparing base (8a744bf) to head (5e4b41a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ComponentDetection.Detectors/pnpm/Pnpm9Detector.cs 94.4% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #1331    +/-   ##
======================================
  Coverage   89.7%   89.7%            
======================================
  Files        387     387            
  Lines      30272   30411   +139     
  Branches    1871    1886    +15     
======================================
+ Hits       27161   27299   +138     
  Misses      2713    2713            
- Partials     398     399     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 19, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@FernandoRojo FernandoRojo merged commit 10c85b6 into main Dec 20, 2024
23 of 26 checks passed
@FernandoRojo FernandoRojo deleted the ferojo/pnpm9FileVersionFix branch December 20, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants