fix: validate --Output
#808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #808 +/- ##
==========================================
+ Coverage 75.81% 75.83% +0.02%
==========================================
Files 239 239
Lines 9959 9962 +3
==========================================
+ Hits 7550 7555 +5
+ Misses 2409 2407 -2
|
annaowens
approved these changes
Sep 26, 2023
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
JamieMagee
reviewed
Sep 26, 2023
| @@ -44,6 +45,11 @@ public override ValidationResult Validate() | |||
| return ValidationResult.Error($"{nameof(this.Timeout)} must be a positive integer"); | |||
| } | |||
|
|
|||
| if (!string.IsNullOrEmpty(this.Output) && !Directory.Exists(this.Output)) | |||
| { | |||
| return ValidationResult.Error($"{nameof(this.Output)} must be a valid path"); | |||
There was a problem hiding this comment.
The description probably needs to be updated
Output path for log files. Defaults to %TMP%
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be validated in the Orchestrator