Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experiments): record rust cli if cargo exists #810

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

melotic
Copy link
Member

@melotic melotic commented Sep 27, 2023

Adds a new InitAsync method to configurations that allows them to do some setup. Useful for the RustCliExperiment as we only want to record this experiment if cargo is available.

This had to be made into a separate method as the experiment methods aren't async, and the CommandLineInvocationService is async.

@melotic melotic added the type:feature Feature (new functionality) label Sep 27, 2023
@melotic melotic requested a review from a team as a code owner September 27, 2023 18:29
@melotic melotic requested a review from grvillic September 27, 2023 18:30
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #810 (6f25bfd) into main (4e87493) will increase coverage by 0.01%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
+ Coverage   75.83%   75.84%   +0.01%     
==========================================
  Files         239      240       +1     
  Lines        9962     9979      +17     
==========================================
+ Hits         7555     7569      +14     
- Misses       2407     2410       +3     
Files Coverage Δ
...tion.Orchestrator/Experiments/ExperimentService.cs 95.04% <100.00%> (+0.59%) ⬆️
...Orchestrator/Services/DetectorProcessingService.cs 91.63% <100.00%> (+0.03%) ⬆️
...or/Experiments/Configs/IExperimentConfiguration.cs 0.00% <0.00%> (ø)
...r/Experiments/Configs/RustCliDetectorExperiment.cs 0.00% <0.00%> (ø)

@melotic melotic merged commit c0fe4af into main Sep 27, 2023
@melotic melotic deleted the justinperez/experiment-init branch September 27, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants