Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): switch new detector to IDefaultOffComponentDetector #811

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

melotic
Copy link
Member

@melotic melotic commented Sep 27, 2023

No description provided.

@melotic melotic added the type:bug Bug fix of existing functionality label Sep 27, 2023
@melotic melotic requested a review from a team as a code owner September 27, 2023 20:56
@melotic melotic requested a review from annaowens September 27, 2023 20:56
@melotic melotic enabled auto-merge (squash) September 27, 2023 20:56
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #811 (7d2b53c) into main (c0fe4af) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #811   +/-   ##
=======================================
  Coverage   75.84%   75.84%           
=======================================
  Files         240      240           
  Lines        9979     9979           
=======================================
  Hits         7569     7569           
  Misses       2410     2410           
Files Coverage Δ
...mponentDetection.Detectors/rust/RustCliDetector.cs 96.00% <ø> (ø)

@melotic melotic merged commit 4560a88 into main Sep 27, 2023
@melotic melotic deleted the justinperez/rust-cli-off branch September 27, 2023 21:00
@github-actions
Copy link

github-actions bot commented Sep 27, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants