Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from clientfactory to regular httpclient #823

Merged
merged 6 commits into from
Oct 3, 2023

Conversation

Omotola
Copy link
Contributor

@Omotola Omotola commented Oct 2, 2023

Pr to Switch from clientfactory to the regular httpclient in the new pip detector

@Omotola Omotola requested a review from a team as a code owner October 2, 2023 16:59
@Omotola Omotola requested a review from JamieMagee October 2, 2023 16:59
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #823 (dbcc749) into main (b1044c7) will decrease coverage by 0.1%.
The diff coverage is 80.0%.

@@           Coverage Diff           @@
##            main    #823     +/-   ##
=======================================
- Coverage   77.4%   77.4%   -0.1%     
=======================================
  Files        235     235             
  Lines       9934    9933      -1     
=======================================
- Hits        7697    7696      -1     
  Misses      2237    2237             
Files Coverage Δ
...estrator/Extensions/ServiceCollectionExtensions.cs 100.0% <ø> (ø)
...mponentDetection.Detectors/pip/SimplePypiClient.cs 89.8% <80.0%> (+<0.1%) ⬆️

@Omotola Omotola enabled auto-merge (squash) October 3, 2023 21:25
@Omotola Omotola merged commit d4c7815 into main Oct 3, 2023
24 checks passed
@Omotola Omotola deleted the users/oakeredolu/removeclientfactory branch October 3, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants