Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Added spdx package component information from SPDX file (#766)" #825

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

sebasgomez238
Copy link
Contributor

Hello, I work on the sbom-tool repo. This commit is causing unwanted information to show up in our sbom-tool. This PR causes packages from an external reference to be detected with the result being all of these detected components to show up as SPDX22SBOM components.

@sebasgomez238 sebasgomez238 requested a review from a team as a code owner October 2, 2023 22:05
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #825 (f7e5cb1) into main (56b3100) will decrease coverage by 0.1%.
The diff coverage is 90.0%.

@@           Coverage Diff           @@
##            main    #825     +/-   ##
=======================================
- Coverage   77.5%   77.4%   -0.1%     
=======================================
  Files        240     235      -5     
  Lines       9984    9934     -50     
=======================================
- Hits        7744    7697     -47     
+ Misses      2240    2237      -3     
Files Coverage Δ
...etection.Detectors/spdx/Spdx22ComponentDetector.cs 82.4% <90.0%> (-1.6%) ⬇️

@melotic melotic merged commit b1044c7 into microsoft:main Oct 3, 2023
20 of 23 checks passed
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants