Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move simple pip to default off #836

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Conversation

Omotola
Copy link
Contributor

@Omotola Omotola commented Oct 6, 2023

move simple pip to default off

@Omotola Omotola requested a review from a team as a code owner October 6, 2023 18:34
@Omotola Omotola requested a review from FernandoRojo October 6, 2023 18:34
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #836 (5747d8a) into main (ae50a41) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #836   +/-   ##
=====================================
  Coverage   77.4%   77.4%           
=====================================
  Files        235     235           
  Lines       9933    9933           
=====================================
  Hits        7696    7696           
  Misses      2237    2237           
Files Coverage Δ
...ection.Detectors/pip/SimplePipComponentDetector.cs 95.2% <ø> (ø)

@melotic melotic merged commit 7221fd4 into main Oct 9, 2023
26 checks passed
@melotic melotic deleted the users/oakeredolu/simplepipdefaultoff branch October 9, 2023 16:36
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants