Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FluentAssertions.Analyzers to Detectors.Tests, fix warnings #879

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Add FluentAssertions.Analyzers to Detectors.Tests, fix warnings #879

merged 2 commits into from
Oct 27, 2023

Conversation

KonH
Copy link
Contributor

@KonH KonH commented Oct 26, 2023

Part of #633

@KonH KonH requested a review from a team as a code owner October 26, 2023 22:00
@KonH KonH requested a review from melotic October 26, 2023 22:00
@KonH KonH mentioned this pull request Oct 26, 2023
Open
5 tasks
melotic
melotic approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@melotic melotic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! some tests are still failing however :(

@JamieMagee
Copy link
Member

Thank you! I'd be happy to merge this once the tests pass 👍

@KonH
Copy link
Contributor Author

KonH commented Oct 27, 2023

All tests now passed.

@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #879 (74431ce) into main (4dcff48) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #879   +/-   ##
=====================================
  Coverage   74.8%   74.8%           
=====================================
  Files        235     235           
  Lines       9953    9953           
  Branches     974     974           
=====================================
  Hits        7449    7449           
  Misses      2231    2231           
  Partials     273     273

@JamieMagee JamieMagee merged commit 53b4059 into microsoft:main Oct 27, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melotic melotic melotic approved these changes

@JamieMagee JamieMagee JamieMagee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KonH @JamieMagee @melotic