Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): don't mark build deps as dev deps #889

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

melotic
Copy link
Member

@melotic melotic commented Nov 5, 2023

Fixes #844

@melotic melotic added type:bug Bug fix of existing functionality detector:rust The Rust Cargo detector labels Nov 5, 2023
@melotic melotic requested a review from a team as a code owner November 5, 2023 21:04
@melotic melotic requested a review from FernandoRojo November 5, 2023 21:04
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #889 (b875d96) into main (b61d0ec) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main    #889   +/-   ##
=====================================
  Coverage   74.8%   74.8%           
=====================================
  Files        235     235           
  Lines       9953    9953           
  Branches     974     974           
=====================================
+ Hits        7449    7450    +1     
  Misses      2231    2231           
+ Partials     273     272    -1     
Files Coverage Δ
...mponentDetection.Detectors/rust/RustCliDetector.cs 100.0% <100.0%> (+1.3%) ⬆️

@melotic melotic merged commit 2701804 into main Nov 6, 2023
26 checks passed
@melotic melotic deleted the justinperez/rust-cli-build branch November 6, 2023 19:22
Copy link

github-actions bot commented Nov 6, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
detector:rust The Rust Cargo detector type:bug Bug fix of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not mark build dependencies as dev dependencies
2 participants