Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing VCPKG Properties #890

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

amitla1
Copy link
Contributor

@amitla1 amitla1 commented Nov 6, 2023

Removing VCPKG Properties because they are not first-class metadata fields of VCPKG.

@amitla1 amitla1 requested a review from a team as a code owner November 6, 2023 18:51
@amitla1 amitla1 requested a review from grvillic November 6, 2023 18:51
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #890 (812665f) into main (b61d0ec) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main    #890     +/-   ##
=======================================
- Coverage   74.8%   74.8%   -0.1%     
=======================================
  Files        235     235             
  Lines       9953    9936     -17     
  Branches     974     971      -3     
=======================================
- Hits        7449    7433     -16     
  Misses      2231    2231             
+ Partials     273     272      -1     
Files Coverage Δ
...tection.Contracts/TypedComponent/VcpkgComponent.cs 76.9% <ø> (-5.3%) ⬇️
...etection.Detectors/vcpkg/VcpkgComponentDetector.cs 79.7% <ø> (ø)

@amitla1 amitla1 merged commit f42b36b into main Nov 6, 2023
25 checks passed
@amitla1 amitla1 deleted the users/avannikumar/removeVCPKGProperties branch November 6, 2023 19:21
Copy link

github-actions bot commented Nov 6, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants