Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote NPM Lockfile v3 detector to run by default #924

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

grvillic
Copy link
Contributor

@grvillic grvillic commented Dec 1, 2023

Self-descriptive PR title

@grvillic grvillic requested a review from a team as a code owner December 1, 2023 22:15
@grvillic grvillic requested a review from amitla1 December 1, 2023 22:15
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4eb61d8) 74.8% compared to head (db088eb) 74.8%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #924   +/-   ##
=====================================
  Coverage   74.8%   74.8%           
=====================================
  Files        235     235           
  Lines       9948    9948           
  Branches     974     974           
=====================================
  Hits        7446    7446           
  Misses      2231    2231           
  Partials     271     271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grvillic grvillic enabled auto-merge (squash) December 1, 2023 22:17
@grvillic grvillic merged commit 5f21f73 into main Dec 1, 2023
25 of 26 checks passed
@grvillic grvillic deleted the users/grvillic/EnableNpmLockv3 branch December 1, 2023 22:25
Copy link

github-actions bot commented Dec 1, 2023

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants