Add Author/License to LinuxComponent #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #934 +/- ##
=======================================
+ Coverage 74.9% 75.0% +0.1%
=======================================
Files 235 235
Lines 10002 10028 +26
Branches 981 988 +7
=======================================
+ Hits 7494 7526 +32
+ Misses 2234 2228 -6
Partials 274 274 ☔ View full report in Codecov by Sentry. |
JamieMagee
reviewed
Dec 18, 2023
src/Microsoft.ComponentDetection.Contracts/TypedComponent/LinuxComponent.cs
Show resolved
Hide resolved
JamieMagee
reviewed
Dec 18, 2023
src/Microsoft.ComponentDetection.Detectors/linux/Contracts/SyftOutput.cs
Outdated
Show resolved
Hide resolved
JamieMagee
approved these changes
Dec 19, 2023
cobya
added
type:feature
cobya
approved these changes
Dec 19, 2023
|
👋 Hi! It looks like you modified some files in the
If none of the above scenarios apply, feel free to ignore this comment 🙂 |
tarun06
pushed a commit
to tarun06/component-detection
that referenced
this pull request
Jan 12, 2024
* Add Author/License to LinuxComponent * Add unit test. Remove comment * Increase coverage. * Feedback * Fix. Only Author and License are nullable. --------- Co-authored-by: Sebastian Gomez <segomez@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Author and License properties from Syft output into the LinuxComponent.