Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exit code check and virtual manifest parsing (RustCli) #937

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix exit code check and virtual manifest parsing (RustCli) #937

merged 2 commits into from
Dec 19, 2023

Conversation

FernandoRojo
Copy link
Contributor

No description provided.

@codecov Codecov
Copy link

codecov bot commented Dec 15, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (ae7438f) 74.9% compared to head (9edebfe) 74.9%.

Files Patch % Lines
...mponentDetection.Detectors/rust/RustCliDetector.cs 42.8% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main    #937     +/-   ##
=======================================
- Coverage   74.9%   74.9%   -0.1%     
=======================================
  Files        235     235             
  Lines       9991    9996      +5     
  Branches     980     981      +1     
=======================================
+ Hits        7487    7488      +1     
- Misses      2231    2234      +3     
- Partials     273     274      +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 15, 2023 •
edited
Loading

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

@FernandoRojo FernandoRojo force-pushed the users/ferojo/rustExitCode branch from 840e56e to 1ed982a Compare December 15, 2023 23:49
@FernandoRojo FernandoRojo marked this pull request as ready for review December 16, 2023 01:05
@FernandoRojo FernandoRojo requested a review from a team as a code owner December 16, 2023 01:05
@FernandoRojo FernandoRojo changed the title Fix exit code check Fix exit code check and virtual manifest parsing (RustCli) Dec 16, 2023
@cobya cobya merged commit d4ca976 into main Dec 19, 2023
24 of 25 checks passed
@cobya cobya deleted the users/ferojo/rustExitCode branch December 19, 2023 18:25
tarun06 pushed a commit to tarun06/component-detection that referenced this pull request Jan 12, 2024
@FernandoRojo @tarun06
Fix exit code check and virtual manifest parsing (RustCli) (microsoft…
11c876c 
…#937)

* Fix exit code check and virtual manifest break

* Update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cobya cobya cobya approved these changes

@JamieMagee JamieMagee Awaiting requested review from JamieMagee JamieMagee is a code owner automatically assigned from microsoft/ose-component-detection-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FernandoRojo @cobya