Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed experiments on released detectors: NPM Lockfile V3 and Nuget #939

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

grvillic
Copy link
Contributor

PR title is self-explanatory.

@grvillic grvillic requested a review from a team as a code owner December 19, 2023 21:50
@grvillic grvillic requested a review from amitla1 December 19, 2023 21:50
@grvillic grvillic enabled auto-merge (squash) December 19, 2023 22:12
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6da1976) 75.0% compared to head (48b2c06) 74.3%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #939     +/-   ##
=======================================
- Coverage   75.0%   74.3%   -0.7%     
=======================================
  Files        235     233      -2     
  Lines      10028   10006     -22     
  Branches     988     984      -4     
=======================================
- Hits        7526    7444     -82     
- Misses      2228    2289     +61     
+ Partials     274     273      -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grvillic grvillic merged commit cf78e59 into main Dec 19, 2023
25 checks passed
@grvillic grvillic deleted the users/grvillic/RemoveShippedExperiments branch December 19, 2023 23:55
Copy link

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

tarun06 pushed a commit to tarun06/component-detection that referenced this pull request Jan 12, 2024
…icrosoft#939)

* Removed experiments on released detectors: NPM Lockfile V3 and Nuget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants