Participant #526
Merged
Participant #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 🚀
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
packages/core/src/expander.ts
Outdated
| @@ -111,6 +111,7 @@ async function callExpander( | |||
| let functions: ChatFunctionCallback[] = [] | |||
| let fileMerges: FileMergeHandler[] = [] | |||
| let outputProcessors: PromptOutputProcessorHandler[] = [] | |||
| let chatParticipants: ChatParticipantHandler[] = [] | |||
There was a problem hiding this comment.
The chatParticipants parameter should be placed after aici to match the order in the function signature.
generated by genaiscript pr-review-commit
ngoiyaeric
reviewed
Jun 10, 2024
| - Be concise. | ||
| - Use simple language. | ||
| - use emojis. | ||
| ` |
There was a problem hiding this comment.
Could you structure the output to jsonl format
There was a problem hiding this comment.
oh good one. let me see if i can add support for JSONL in outputs.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library Changes
ChatParticipantHandlerwhich is a function that takes an array ofChatCompletionMessageParamand returns aPromise<string>.chatParticipantsas an array ofChatParticipantHandlerin various parts of the codebase:executeChatSessionfunction inchat.tsnow acceptschatParticipantsas an additional parameter.callExpanderfunction inexpander.tsnow initializes and includeschatParticipantsin its return object.expandTemplatefunction inexpander.tsnow includeschatParticipantsin its processing logic.createPromptContextfunction inpromptcontext.tsnow provides adefChatParticipantmethod to define a chat participant.PromptNodeinterface inpromptdom.tshas a new type"chatParticipant"to represent chat participant nodes.createChatParticipantfunction inpromptdom.tscreates a newPromptChatParticipantNode.renderPromptNodefunction inpromptdom.tsnow handleschatParticipantnodes and includes them in thePromptNodeRenderinterface.runTemplatefunction inpromptrunner.tsnow includeschatParticipantsin its execution flow.createRunPromptContextfunction inrunpromptcontext.tsnow supportschatParticipantsand includes them in the execution context.CLI Changes