use llmified keys for github #751

pelikhan · 2024-10-03T01:24:52Z

A new naming convention has been established, assigning unique identifiers prefixed by llm_. This change affects various GitHub tools:
- github_actions_workflows_list
- github_actions_runs_list
- github_actions_jobs_list
- github_actions_workflows_list
- github_issues_list
- github_issues_get
- github_issues_comments_list
- github_pulls_list
- github_pulls_get
- github_pulls_review_comments_list
This likely provides a more consistent way to refer to these resources across different contexts, improving code maintainability and readability.
The data fields in responses of the aforementioned tools are also renamed to follow the new llm_ prefixed ID pattern.
Over in the packages/core/src/github.ts file, code is adjusted to handle these new llm_ IDs.
Additionally, new constants are exported in the packages/core/src/constants.ts file, probably used for the prefix mentioned earlier for better coding practices.
A new file packages/core/src/llmid.ts is introduced to handle functions related to the ID conversion, like llmifyId, unllmifyIntId, and unllmifyId.
In the public API, additional llm_id fields have been added to the interfaces for GitHubWorkflowRun, GitHubWorkflowJob, GitHubIssue, GitHubComment, and GitHubWorkflow.
These interface changes indicate the llm_id values are intended to be exposed to and used by end-users or developers.
Lastly, unrelated to the llm_ ID changes, there are some minor fixes or adjustments in the packages/sample/genaisrc/poem.genai.mts file.

generated by pr-describe

…tool interoperability

…tion

github-actions · 2024-10-03T01:25:56Z

docs/src/components/BuiltinTools.mdx

-<LinkCard title="github_actions_jobs_list" description="List all jobs for a run." href="/genaiscript/reference/scripts/system#systemgithub_actions" />
+<LinkCard title="github_actions_workflows_list" description="List all workflows. 'llm_id' is the ID used in other tools." href="/genaiscript/reference/scripts/system#systemgithub_actions" />
+<LinkCard title="github_actions_runs_list" description="List all runs for a workflow. 'llm_id' is the ID used in other tools. Use 'git_actions_list_workflows' to list workflows." href="/genaiscript/reference/scripts/system#systemgithub_actions" />
+<LinkCard title="github_actions_jobs_list" description="List all jobs for a run. 'llm_id' is the ID used in other tools." href="/genaiscript/reference/scripts/system#systemgithub_actions" />
 <LinkCard title="github_actions_job_logs_get" description="Download workflow job log. If the log is too large, use 'github_actions_job_logs_diff' to compare logs." href="/genaiscript/reference/scripts/system#systemgithub_actions" />
 <LinkCard title="github_actions_job_logs_diff" description="Diffs two workflow job logsr." href="/genaiscript/reference/scripts/system#systemgithub_actions" />


Typo in the word "logsr", should be "logs".

generated by pr-docs-review-commit typo

github-actions · 2024-10-03T01:25:57Z

docs/src/content/docs/reference/scripts/system.mdx

-  tool `github_actions_jobs_list`: List all jobs for a run.
+-  tool `github_actions_workflows_list`: List all workflows. 'llm_id' is the ID used in other tools.
+-  tool `github_actions_runs_list`: List all runs for a workflow. 'llm_id' is the ID used in other tools. Use 'git_actions_list_workflows' to list workflows.
+-  tool `github_actions_jobs_list`: List all jobs for a run. 'llm_id' is the ID used in other tools.
 -  tool `github_actions_job_logs_get`: Download workflow job log. If the log is too large, use 'github_actions_job_logs_diff' to compare logs.
 -  tool `github_actions_job_logs_diff`: Diffs two workflow job logsr.


Typo in the word "logsr", should be "logs".

generated by pr-docs-review-commit typo

github-actions · 2024-10-03T01:25:58Z

docs/src/content/docs/reference/scripts/system.mdx

    {},
    async (args) => {
        const { context } = args
        context.log("github action list workflows")
        const res = await github.listWorkflows()
        return CSV.stringify(
-            res.map(({ id, name, path }) => ({ id, name, path })),
+            res.map(({ llm_id, name, path }) => ({ llm_id, name, path })),


The variable 'llm_id' should be 'id' to match the context and the rest of the documentation.

generated by pr-docs-review-commit incorrect_variable

github-actions · 2024-10-03T01:25:59Z

docs/src/content/docs/reference/scripts/system.mdx

-            res.map(({ id, name, conclusion, head_sha }) => ({
-                id,
+            res.map(({ llm_id, name, conclusion, head_sha }) => ({
+                llm_id,
                name,


The variable 'llm_id' should be 'id' to match the context and the rest of the documentation.

generated by pr-docs-review-commit incorrect_variable

github-actions · 2024-10-03T01:25:59Z

docs/src/content/docs/reference/scripts/system.mdx

+                llm_id,
+                name,
+                status,
+            })),


The variable 'llm_id' should be 'id' to match the context and the rest of the documentation.

generated by pr-docs-review-commit incorrect_variable

github-actions · 2024-10-03T01:26:00Z

docs/src/content/docs/reference/scripts/system.mdx

+                llm_number,
+                title,
+                state,
+            })),


The variable 'llm_number' should be 'number' to match the context and the rest of the documentation.

generated by pr-docs-review-commit incorrect_variable

github-actions · 2024-10-03T01:26:01Z

docs/src/content/docs/reference/scripts/system.mdx

            await github.getIssue(issue_number)
        return YAML.stringify({
-            number,
+            llm_number,


The variable 'llm_number' should be 'number' to match the context and the rest of the documentation.

generated by pr-docs-review-commit incorrect_variable

github-actions · 2024-10-03T01:26:02Z

docs/src/content/docs/reference/scripts/system.mdx

-            res.map(({ id, body, updated_at }) => ({
-                id,
+            res.map(({ llm_id, body, updated_at }) => ({
+                llm_id,
                body,
                updated_at,
            })),


The variable 'llm_id' should be 'id' to match the context and the rest of the documentation.

generated by pr-docs-review-commit incorrect_variable

github-actions · 2024-10-03T01:26:02Z

docs/src/content/docs/reference/scripts/system.mdx

                number,
+                llm_number,
                title,
                state,
            })),


The variable 'llm_number' should be 'number' to match the context and the rest of the documentation.

generated by pr-docs-review-commit incorrect_variable

github-actions · 2024-10-03T01:26:03Z

docs/src/content/docs/reference/scripts/system.mdx

            await github.getPullRequest(pull_number)
        return YAML.stringify({
            number,
+            llm_number,
            title,
            body,


The variable 'llm_number' should be 'number' to match the context and the rest of the documentation.

generated by pr-docs-review-commit incorrect_variable

github-actions · 2024-10-03T01:26:04Z

packages/core/src/github.ts

+                    state,
+                    html_url,
+                    created_at,
+                }


Missing type assertion for the return value of the map function. TypeScript might infer the wrong type.

generated by pr-review-commit missing_type_assertion

github-actions · 2024-10-03T01:26:04Z

docs/src/content/docs/reference/scripts/system.mdx

@@ -1393,7 +1403,7 @@ defTool(
        context.log(`github pull comments list ${pull_number}`)
        const res = await github.listPullRequestReviewComments(pull_number)
        return CSV.stringify(
-            res.map(({ id, body }) => ({ id, body })),
+            res.map(({ id, llm_id, body }) => ({ id, llm_id, body })),
            { header: true }


The variable 'llm_id' should be 'id' to match the context and the rest of the documentation.

generated by pr-docs-review-commit incorrect_variable

github-actions · 2024-10-03T01:26:04Z

packages/core/src/github.ts

+            state,
+            html_url,
+            created_at,
+        }


Missing type assertion for the return value of the function. TypeScript might infer the wrong type.

generated by pr-review-commit missing_type_assertion

github-actions · 2024-10-03T01:26:05Z

packages/core/src/github.ts

+                    state,
+                    html_url,
+                    created_at,
+                }


Missing type assertion for the return value of the map function. TypeScript might infer the wrong type.

generated by pr-review-commit missing_type_assertion

github-actions · 2024-10-03T01:26:32Z

The changes in the GIT_DIFF consist of a few key updates:

Addition of new constants, presumably identifiers, in the constants file.
Use of these new constants in the github.ts file where they seem to be used for creating a format for ID references, referred to as "llm_id". This involves updating various functions in the GitHubClient class to use and return these new formatted IDs.
Creation of a new file, llmid.ts, which seems to contain functions necessary for constructing and deconstructing these new ID formats.
Updates to types in the prompt_template.d.ts file to reflect the use of these new 'llm_id's in the GitHub interfaces.

Concerns:

The conversion functions in llmid.ts do not guard against invalid inputs, which may result in unexpected output.
There is a general assumption that the 'llm_id' conversion and deconversion will always work correctly, but there are no explicit error checks or handling mechanisms to ensure this.
In the GitHubClient class, the 'listWorkflowJobs' function now allows the 'runId' parameter to be either a number or a string, but there are no checks to ensure the string is a valid input.

Other than these, the changes look good and it's a smart way to create a unique identifier. LGTM 🚀

generated by pr-review

github-actions · 2024-10-03T01:27:36Z

I couldn't locate the specific code responsible for the failure. Please check if the file path and name are correct or provide further details.

generated by gai

github-actions · 2024-10-03T01:27:56Z

It seems there is a persistent issue with retrieving the changes. If you have access to the repository, you might want to manually check the recent commits between the failed and last successful runs.

Given the failure was related to a Node.js version issue, consider reviewing any changes related to package dependencies or Node.js version specifications in the workflow configuration.

generated by github-agent

pelikhan added 4 commits October 3, 2024 01:13

Refactor GitHub Actions integration to include 'llm_id' for improved …

02594e8

…tool interoperability

Add variable 'x' to poem.genai.mts file.

7026599

Add LLM ID support to GitHub issue and pull request tools for integra…

11e1fc7

…tion

Remove unused 'id' and 'number' fields and update sample poem file.

d3c39b7

pelikhan changed the title ~~Llmkeys~~ use llmified keys for github Oct 3, 2024

github-actions bot reviewed Oct 3, 2024

View reviewed changes

pelikhan closed this Oct 3, 2024

pelikhan deleted the llmkeys branch October 4, 2024 01:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use llmified keys for github #751

use llmified keys for github #751

pelikhan commented Oct 3, 2024 •

edited by github-actions bot

Loading

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

use llmified keys for github #751

use llmified keys for github #751

Conversation

pelikhan commented Oct 3, 2024 • edited by github-actions bot Loading

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot Oct 3, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

pelikhan commented Oct 3, 2024 •

edited by github-actions bot

Loading