Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 127.0.0.1 #968

Merged
merged 5 commits into from
Dec 27, 2024
Merged

use 127.0.0.1 #968

merged 5 commits into from
Dec 27, 2024

Conversation

pelikhan
Copy link
Member

@pelikhan pelikhan commented Dec 26, 2024

Some consumer machines do not have the localhost loopback by default.


Sure! Here's a high-level summary of the changes in the GIT_DIFF with an engaging description:

  • 🌐 Network Configuration Update:

    • All API base URLs have been updated to use 127.0.0.1 instead of localhost. This enforces local-only connections, enhancing security.
  • 🏃 Server Manager Endpoint Modification:

    • The WebSocket server in servermanager.ts now connects to a local URL using 127.0.0.1.
  • 📄 LLM JSON Update:

    • A new property top_p was added to the jan object in llms.json. This likely indicates support for a probability threshold in language model predictions.
  • 📜 Constants.ts Enhancements:

    • New constants like LMSTUDIO_API_BASE and JAN_API_BASE have been added to expand the set of supported APIs.
  • 💼 Refactoring and Cleanup:

    • Comments suggesting changes indicate that certain lines may need to be updated depending on further requirements or API documentation updates.

These changes aim to improve security, local control over services, and add features that could enhance language model capabilities.

AI-generated content by pr-describe may be incorrect

Copy link

LGTM 🚀 🎉 The changes seem to be relevant and improve the configuration of API endpoints. They also update URLs from localhost to 127.0.0.1, which is a good practice for security purposes as it restricts access to local network interfaces only.

AI-generated content by pr-review may be incorrect

@pelikhan pelikhan merged commit df060c1 into main Dec 27, 2024
13 checks passed
@pelikhan pelikhan deleted the janaimodels branch December 27, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant