Skip to content

Commit

Permalink
Fixes #1873: Can a client use window/workDoneProgress/cancel to cance…
Browse files Browse the repository at this point in the history
…l a progress token provided by the client? (#1877)
  • Loading branch information
dbaeumer authored Jan 8, 2024
1 parent 637fd27 commit 74c0687
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion _specifications/base/0.9/specification.md
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,8 @@ A server uses the `workDoneToken` to report progress for the specific `build/dep
}
```

The token received via the `workDoneToken` property in a request's param literal is only valid as long as the request has not send a response back.
The token received via the `workDoneToken` property in a request's param literal is only valid as long as the request has not send a response back. Canceling work done progress is done by simply
canceling the corresponding request.

There is no specific client capability signaling whether a client will send a progress token per request. The reason for this is that this is in many clients not a static aspect and might even change for every request instance for the same request type. So the capability is signal on every request instance by the presence of a `workDoneToken` property.

Expand Down
3 changes: 2 additions & 1 deletion _specifications/lsp/3.17/types/workDoneProgress.md
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ A server uses the `workDoneToken` to report progress for the specific `textDocum
}
```

The token received via the `workDoneToken` property in a request's param literal is only valid as long as the request has not send a response back.
The token received via the `workDoneToken` property in a request's param literal is only valid as long as the request has not send a response back. Canceling work done progress is done by simply
canceling the corresponding request.

There is no specific client capability signaling whether a client will send a progress token per request. The reason for this is that this is in many clients not a static aspect and might even change for every request instance for the same request type. So the capability is signal on every request instance by the presence of a `workDoneToken` property.

Expand Down
3 changes: 2 additions & 1 deletion _specifications/lsp/3.18/types/workDoneProgress.md
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,8 @@ A server uses the `workDoneToken` to report progress for the specific `textDocum
}
```

The token received via the `workDoneToken` property in a request's param literal is only valid as long as the request has not send a response back.
The token received via the `workDoneToken` property in a request's param literal is only valid as long as the request has not send a response back. Canceling work done progress is done by simply
canceling the corresponding request.

There is no specific client capability signaling whether a client will send a progress token per request. The reason for this is that this is in many clients not a static aspect and might even change for every request instance for the same request type. So the capability is signal on every request instance by the presence of a `workDoneToken` property.

Expand Down

0 comments on commit 74c0687

Please sign in to comment.