-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always creating worker threads without affinitization on error. #3041
Conversation
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
@nibanks can we get this change in msquic servicing branch release/2.1? We need to be able to determine version of msquic library (and which which backend we use - OpenSSL or Schannel) without inflicting the cost of keeping msquic threads in apps that do not use msquic. Currently all the threads are consuming some memory and they are confusing users who do deep dive into perf of their app. BTW: In ideal world, we would like to avoid unloading msquic entirely, so if you are ok to do lazy initialization of threads in servicing, we would be thrilled. |
Yes, that should be fine. |
@rzikm would you mine creating a PR to cherry-pick this into the release/2.1 branch? |
Description
On combination Docker+Debian11+ARM64, the call to pthread_create sometimes returns EINVAL when attempting thread affinitization. This PR always retries thread creation without thread affinitization when the first call to pthread_create fails.
Related to dotnet/runtime#74952
Testing
Tested manually on the affected platform.
Documentation
NO