Skip to content

Commit

Permalink
Avoid using env allocator by default (#945)
Browse files Browse the repository at this point in the history
  • Loading branch information
baijumeswani authored Sep 30, 2024
1 parent 5a97d05 commit 8d28f20
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@ struct Config {
std::optional<std::string> log_id;
std::optional<int> log_severity_level;
std::optional<std::string> enable_profiling;
bool use_env_allocators{true};
// TODO(baijumeswani): Sharing env allocators across sessions leads to crashes on windows and iOS.
// Identify the reason for the crash to enable allocator sharing by default.
bool use_env_allocators{false};

std::vector<ProviderOptions> provider_options;
};
Expand Down Expand Up @@ -168,4 +170,4 @@ void SetSearchNumber(Config::Search& search, std::string_view name, double value
void SetSearchBool(Config::Search& search, std::string_view name, bool value);
bool IsCudaGraphEnabled(Config::SessionOptions& session_options);

} // namespace Generators
} // namespace Generators

0 comments on commit 8d28f20

Please sign in to comment.