Initialize Objective-C bindings #709
Conversation
| @@ -0,0 +1,27 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
There was a problem hiding this comment.
Copied from onnxruntime repo: https://github.com/microsoft/onnxruntime/blob/main/objectivec/error_utils.h
|
|
||
| #import "oga_internal.h" | ||
|
|
||
| @implementation OGAInt32Span { |
There was a problem hiding this comment.
This is to mimic std::span which is not available until C++ 20, also not suitable in an ObjC environment.
| OGA_OBJC_API_IMPL_CATCH_RETURNING_BOOL(error) | ||
| } | ||
|
|
||
| - (BOOL)setInputSequences:(OGASequences*)sequences error:(NSError**)error { |
There was a problem hiding this comment.
Using the C# bindings as the base example, should there also be an equivalent of setInputIds?
| - (int32_t)last { | ||
| return *(_ptr + (_size - 1)); | ||
| } |
There was a problem hiding this comment.
What's the use case for this? std::span has things like begin and end but that's slightly different to returning the value of the last element (and this would also do the wrong thing if size was 0 wouldn't it)?
There was a problem hiding this comment.
The use case of this is to retrieve the last element of the generated sequence for streaming output. The [^1] part of the following code:
You're right it would fail if size is 0. Will try to improve this.
| - (nullable OGASequences*)encode:(NSString*)str error:(NSError**)error { | ||
| OGASequences* sequences = [[OGASequences alloc] initWithError:error]; | ||
| if (*error) { | ||
| return nil; | ||
| } | ||
| try { | ||
| _tokenizer->Encode([str UTF8String], [sequences CXXAPIOgaSequences]); | ||
| return sequences; | ||
| } | ||
| OGA_OBJC_API_IMPL_CATCH_RETURNING_NULLABLE(error) | ||
| } | ||
|
|
||
| - (nullable NSString*)decode:(OGAInt32Span*)data error:(NSError**)error { |
There was a problem hiding this comment.
The C# API has encode/decode of batches. Is there a reason for this to be inconsistent and only support a single input?
There was a problem hiding this comment.
No. This PR is just the first step towards a usable example. More methods including batches support will be added.
|
|
||
| @end | ||
|
|
||
| @implementation OGATokenizerStream { |
There was a problem hiding this comment.
nit: could this be in oga_tokenizer_stream.mm? we usually keep it 1:1 between non-trivial types and the file they're in
This PR contains only Objective-C wrapper code. Examples, podspec and building infras are yet to be done.
Internal workitem: https://task.ms/aii/35199