Remove redundant config copy from GeneratorParams #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t holds a pointer to config now.
…into ryanunderhill/api_params
yufenglee
approved these changes
Sep 25, 2024
baijumeswani
approved these changes
Sep 25, 2024
skyline75489
pushed a commit
to skyline75489/onnxruntime-genai
that referenced
this pull request
Sep 26, 2024
Some model config options were being copied into the GeneratorParams and then relayed to the Generator functions, this is unnecessary and confusing. Instead the GeneratorParams just holds a pointer to the config and these options are now taken directly from the config. This simplifies the GeneratorParams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some model config options were being copied into the GeneratorParams and then relayed to the Generator functions, this is unnecessary and confusing. Instead the GeneratorParams just holds a pointer to the config and these options are now taken directly from the config.
This simplifies the GeneratorParams