Add Get/Set logits functions to Python #956
Open
+27
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajindal1
approved these changes
Oct 6, 2024
| @@ -432,6 +443,8 @@ PYBIND11_MODULE(onnxruntime_genai, m) { | |||
| .def("is_done", &PyGenerator::IsDone) | |||
| .def("compute_logits", &PyGenerator::ComputeLogits) | |||
| .def("get_output", &PyGenerator::GetOutput) | |||
| .def("get_logits", &PyGenerator::GetLogits) | |||
| .def("set_logits", &PyGenerator::SetLogits) | |||
There was a problem hiding this comment.
Do get_logits() and set_logits() work with float16 and float32 precision or only float32 precision?
|
Do we need the C/C++ equivalent functions? Could we also add a unit test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes an issue with the ToPython function, arrays returned were all the same element due to the stride being set to zero. This calls the explicit constructor.