Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support for building the iOS simulator arm64 version #22257

Open
cyanic-selkie opened this issue Sep 28, 2024 · 2 comments
Labels
feature request request for unsupported feature or enhancement platform:mobile issues related to ONNX Runtime mobile; typically submitted using template

Comments

@cyanic-selkie
Copy link

Describe the feature request

Currently, the build script only supports the x86_64 architecture for the iOS simulator. Since the M series Macbooks are arm64, this doesn't work.

Describe scenario use case

Adding this would make development on an M series Macbook easier and more straightforward.

@cyanic-selkie cyanic-selkie added the feature request request for unsupported feature or enhancement label Sep 28, 2024
@github-actions github-actions bot added the platform:mobile issues related to ONNX Runtime mobile; typically submitted using template label Sep 28, 2024
@cyanic-selkie
Copy link
Author

My apologies, apparently this is already supported. This should've been a bug report.

The issue I was facing was the fact that building for the simulator after building for the iOS target without deleting the build directory first (or vice versa), it would try to link to the wrong dylib (built for the other target).

@skottmckay
Copy link
Contributor

Depending on how the cmake files are written some values may be 'sticky' across builds (e.g. we set a value inside a branch but don't have a matching branch that unsets it). If you're changing a significant aspect of the build it's generally better to use a clean build directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request request for unsupported feature or enhancement platform:mobile issues related to ONNX Runtime mobile; typically submitted using template
Projects
None yet
Development

No branches or pull requests

2 participants