Clean up build.py #19156
Clean up build.py #19156
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
lintrunner found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
"""Base class for errors originating from build.py."""
pass
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
# Conflicts: # tools/ci_build/build.py
Can you clarify what "nonessential" means? I gather it's different from "unused", but it seems that anything that is used is "essential" in some way. I ask so that when we add new functions in the future we know where to put them. |
We can put all future helper functions into the files from |
|
@jchen351, Is it still needed? If not, please close it. |
# Conflicts: # tools/ci_build/build.py
| raise BuildError( | ||
| "cuda_home and cudnn_home paths must be specified and valid.", | ||
| f"cuda_home='{cuda_home}' valid={cuda_home_valid}. cudnn_home='{cudnn_home}'" | ||
| f" valid={cudnn_home_valid}",, |
Check failure
Code scanning / CodeQL
Syntax error Error
Description
Clean up build.py
Motivation and Context
Moving nonessential functions to the onnxruntime/tools/python/util package. Only left function that are meaningful to the build process.