[WebNN EP] Support ConvTranspose for TFLite backend #21291

Honry · 2024-07-09T05:13:26Z

Description

Chromium supports ConvTranspose for TFLite in
https://chromium-review.googlesource.com/c/chromium/src/+/5635194

With constraint that only default dilations and groups are supported.

Honry · 2024-07-09T05:13:47Z

@fdwr, @guschmue, PTAL, thanks!

guschmue · 2024-07-11T19:54:50Z

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

guschmue · 2024-07-11T19:54:56Z

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

guschmue · 2024-07-11T19:55:04Z

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

azure-pipelines · 2024-07-11T19:55:07Z

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines · 2024-07-11T19:55:32Z

Azure Pipelines successfully started running 7 pipeline(s).

azure-pipelines · 2024-07-11T19:55:32Z

Azure Pipelines successfully started running 9 pipeline(s).

Honry · 2024-07-16T03:16:21Z

@guschmue, @fdwr, looks like the CI failure is irrelevant to my change. Could you pls. help retrigger them? Thanks!

fdwr · 2024-07-17T21:57:50Z

/azp run Windows GPU CI Pipeline

azure-pipelines · 2024-07-17T21:58:01Z

Azure Pipelines successfully started running 1 pipeline(s).

fdwr

Is this a regression relative to XNNPack then?

Honry · 2024-07-18T01:18:03Z

Is this a regression relative to XNNPack then?

Umm, not sure, @fujunwei may help answer this.

onnxruntime/core/providers/webnn/builders/impl/conv_op_builder.cc

fdwr · 2024-07-19T02:04:38Z

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

fdwr · 2024-07-19T02:04:44Z

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

fdwr · 2024-07-19T02:04:48Z

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

fdwr · 2024-07-19T02:32:17Z

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

fdwr · 2024-07-19T02:33:58Z

@Honry Consider merging from main again, which might help the failed tests (also, I can't approve because I fixed the lint issue, and you're not allowed to approve when you were the last pusher).

fdwr · 2024-07-19T02:51:21Z

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

fdwr · 2024-07-19T02:51:27Z

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

fdwr · 2024-07-19T02:51:31Z

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

azure-pipelines · 2024-07-19T03:03:45Z

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines · 2024-07-19T03:03:59Z

Azure Pipelines successfully started running 7 pipeline(s).

azure-pipelines · 2024-07-19T03:04:08Z

Azure Pipelines successfully started running 9 pipeline(s).

fdwr · 2024-07-25T05:37:15Z

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

fdwr · 2024-07-25T05:37:17Z

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

fdwr · 2024-07-25T05:37:21Z

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

azure-pipelines · 2024-07-25T05:37:32Z

Azure Pipelines successfully started running 3 pipeline(s).

azure-pipelines · 2024-07-25T05:37:49Z

Azure Pipelines successfully started running 7 pipeline(s).

azure-pipelines · 2024-07-25T05:37:51Z

Azure Pipelines successfully started running 9 pipeline(s).

fdwr · 2024-07-25T07:37:43Z

/azp run Windows CPU CI Pipeline

fdwr · 2024-07-25T07:37:51Z

/azp run Windows GPU CI Pipeline

azure-pipelines · 2024-07-25T07:37:54Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2024-07-25T07:38:00Z

Azure Pipelines successfully started running 1 pipeline(s).

fdwr · 2024-07-26T02:20:28Z

/azp run Windows GPU CI Pipeline

azure-pipelines · 2024-07-26T02:20:39Z

Azure Pipelines successfully started running 1 pipeline(s).

Chromium supports ConvTranspose for TFLite in https://chromium-review.googlesource.com/c/chromium/src/+/5635194 With constraint that only default dilations and groups are supported.

fdwr · 2024-07-30T03:29:08Z

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

fdwr · 2024-07-30T03:29:12Z

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

fdwr · 2024-07-30T03:29:17Z

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

azure-pipelines · 2024-07-30T03:29:21Z

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines · 2024-07-30T03:29:44Z

Azure Pipelines successfully started running 7 pipeline(s).

azure-pipelines · 2024-07-30T03:29:45Z

Azure Pipelines successfully started running 9 pipeline(s).

fdwr · 2024-07-30T05:09:21Z

/azp run Windows GPU TensorRT CI Pipeline

azure-pipelines · 2024-07-30T05:09:31Z

Azure Pipelines successfully started running 1 pipeline(s).

fdwr · 2024-07-30T06:55:00Z

/azp run Windows GPU TensorRT CI Pipeline

azure-pipelines · 2024-07-30T06:55:11Z

Azure Pipelines successfully started running 1 pipeline(s).

fdwr · 2024-07-31T00:45:46Z

The ORT Web CI pipeline issue appears unrelated to this change:

gmake: *** [Makefile:720: onnxruntime_webassembly] Error 2
...
[onnxruntime-extensions] Loading onnxruntime-extensions from: FetchContent

Continuing merge.

satyajandhyala · 2024-07-31T16:56:30Z

onnxruntime/core/providers/webnn/builders/impl/conv_op_builder.cc

@@ -427,6 +427,22 @@ bool ConvOpBuilder::HasSupportedInputsImpl(const Node& node, const WebnnDeviceTy
    return false;
  }

+  // WebNN CPU backend (TFLite) only supports default dilations and group.
+  // https://source.chromium.org/chromium/chromium/src/+/main:services/webnn/tflite/graph_builder_tflite.cc;l=1040
+  if (device_type == WebnnDeviceType::CPU && op_type == "ConvTranspose") {


device_type variable is undefined

Arg, I would appreciate less misleading output from the build process.

Follow up fix here: #21569

guschmue added the ep:WebNN WebNN execution provider label Jul 11, 2024

fdwr previously approved these changes Jul 17, 2024

View reviewed changes

fdwr reviewed Jul 19, 2024

View reviewed changes

onnxruntime/core/providers/webnn/builders/impl/conv_op_builder.cc Outdated Show resolved Hide resolved

fdwr dismissed their stale review via 5d15e4b July 19, 2024 02:04

fdwr previously approved these changes Jul 19, 2024

View reviewed changes

Honry force-pushed the tflite-convTranspose2d branch from 5d15e4b to 13d8868 Compare July 19, 2024 02:41

Honry dismissed fdwr’s stale review via c647e2c July 19, 2024 02:45

fdwr approved these changes Jul 19, 2024

View reviewed changes

Honry force-pushed the tflite-convTranspose2d branch from e17fb59 to 2101656 Compare July 25, 2024 05:33

Honry and others added 3 commits July 30, 2024 11:15

[WebNN EP] Support ConvTranspose for TFLite backend

478eac6

Chromium supports ConvTranspose for TFLite in https://chromium-review.googlesource.com/c/chromium/src/+/5635194 With constraint that only default dilations and groups are supported.

Update onnxruntime/core/providers/webnn/builders/impl/conv_op_builder.cc

6e144a4

Fix typos

8abdd79

Honry force-pushed the tflite-convTranspose2d branch from 2101656 to 8abdd79 Compare July 30, 2024 03:18

fdwr merged commit 1d4b161 into microsoft:main Jul 31, 2024
64 of 67 checks passed

satyajandhyala reviewed Jul 31, 2024

View reviewed changes

[WebNN EP] Support ConvTranspose for TFLite backend #21291

[WebNN EP] Support ConvTranspose for TFLite backend #21291

Conversation

Honry commented Jul 9, 2024

Description

Honry commented Jul 9, 2024

guschmue commented Jul 11, 2024

guschmue commented Jul 11, 2024

guschmue commented Jul 11, 2024

azure-pipelines bot commented Jul 11, 2024

azure-pipelines bot commented Jul 11, 2024

azure-pipelines bot commented Jul 11, 2024

Honry commented Jul 16, 2024

fdwr commented Jul 17, 2024

azure-pipelines bot commented Jul 17, 2024

fdwr left a comment

Choose a reason for hiding this comment

Honry commented Jul 18, 2024

fdwr commented Jul 19, 2024

fdwr commented Jul 19, 2024

fdwr commented Jul 19, 2024

fdwr commented Jul 19, 2024

fdwr commented Jul 19, 2024

fdwr commented Jul 19, 2024

fdwr commented Jul 19, 2024

fdwr commented Jul 19, 2024

azure-pipelines bot commented Jul 19, 2024

azure-pipelines bot commented Jul 19, 2024

azure-pipelines bot commented Jul 19, 2024

fdwr commented Jul 25, 2024

fdwr commented Jul 25, 2024

fdwr commented Jul 25, 2024

azure-pipelines bot commented Jul 25, 2024

azure-pipelines bot commented Jul 25, 2024

azure-pipelines bot commented Jul 25, 2024

fdwr commented Jul 25, 2024

fdwr commented Jul 25, 2024

azure-pipelines bot commented Jul 25, 2024

azure-pipelines bot commented Jul 25, 2024

fdwr commented Jul 26, 2024

azure-pipelines bot commented Jul 26, 2024

fdwr commented Jul 30, 2024

fdwr commented Jul 30, 2024

fdwr commented Jul 30, 2024

azure-pipelines bot commented Jul 30, 2024

azure-pipelines bot commented Jul 30, 2024

azure-pipelines bot commented Jul 30, 2024

fdwr commented Jul 30, 2024

azure-pipelines bot commented Jul 30, 2024

fdwr commented Jul 30, 2024

azure-pipelines bot commented Jul 30, 2024

fdwr commented Jul 31, 2024

satyajandhyala Jul 31, 2024

Choose a reason for hiding this comment

fdwr Jul 31, 2024

Choose a reason for hiding this comment

fdwr Aug 1, 2024

Choose a reason for hiding this comment