CoreML: Add ML Program Concat #21423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vraspar
commented
Jul 20, 2024
There was a problem hiding this comment.
Concat op also needs changes that as ConvTranspose. The model.mm is same as #21416
skottmckay
reviewed
Jul 20, 2024
onnxruntime/core/providers/coreml/builders/impl/builder_utils.h
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/concat_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/concat_op_builder.cc
Outdated
Show resolved
Hide resolved
skottmckay
reviewed
Jul 22, 2024
Co-authored-by: Scott McKay <skottmckay@gmail.com>
…der.cc Co-authored-by: Scott McKay <skottmckay@gmail.com>
…der.cc Co-authored-by: Scott McKay <skottmckay@gmail.com>
edgchen1
reviewed
Jul 22, 2024
edgchen1
reviewed
Jul 22, 2024
onnxruntime/core/providers/coreml/builders/impl/builder_utils.cc
Outdated
Show resolved
Hide resolved
skottmckay
added a commit
that referenced
this pull request
Jul 24, 2024
- Add Concat (#21423) - Add DepthToSpace (#21426) - Add LeakyRelu (#21453) - Add test scripts (#21427) - Add ability to set coreml flags from python (#21434) Also updated partitioning utils to support dropping constant initializers from a ComputeCapability's inputs. We copy these to a CoreML model so don't need the originals. If they remain as inputs ORT can't free them as they appear to be in use. Misc changes - Fix SkipLayerNormFusion incorrectly setting `modified` - causes unnecessary loops of the L2 transformers
|
Included in #21472 |
skottmckay
added a commit
that referenced
this pull request
Jul 25, 2024
…#21472) ### Description <!-- Describe your changes. --> Add these changes to one PR to simplify checkin - Add Concat (#21423) - Add DepthToSpace (#21426) - Add LeakyRelu (#21453) - Add test scripts (#21427) - Add ability to set coreml flags from python (#21434) Other changes - updated partitioning utils to support dropping constant initializers from a ComputeCapability's inputs. - noticed that the list of inputs to the coreml model was unexpectedly long due to this - we copy constant initializers to a CoreML model so don't need the originals, and if they remain as inputs ORT can't free them as they appear to be in use. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add CoreML ML Program Concat
Motivation and Context
Support priority models