Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIX]test failure fix using gtest-1.15.0 for AIX #21497

Merged

Conversation

ranjitshs
Copy link
Contributor

Description

Local CI setup for AIX reported tests failure after the gtest 1.15.0 upgrade.

Motivation and Context

Below tests failure is observed after gtest upgrade.

The following tests FAILED:
1 - onnxruntime_test_all (ILLEGAL)
7 - onnxruntime_logging_apis_test (Subprocess aborted)

To fix this, I am enabling pthread support under gtest. This was disabled with previous version of gtest for some reason.
Now by enabling this, above tests are getting passed with gtest 1.15.0.

@ranjitshs
Copy link
Contributor Author

@snnn
As mentioned in #21410 , this PR contains the AIX test failure fix with gtest 1.15.0.
Please trigger the relevant CI pipeline and let me know if I need to create a corresponding issue.

@tianleiwu FYI.

@ranjitshs ranjitshs changed the title test failure fix using gtest-1.15.0 for AIX [AIX]test failure fix using gtest-1.15.0 for AIX Jul 25, 2024
@snnn
Copy link
Member

snnn commented Jul 25, 2024

/azp run Big Models, Linux Android Emulator QNN CI Pipeline, Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline, MacOS CI Pipeline

@snnn
Copy link
Member

snnn commented Jul 25, 2024

/azp run Windows ARM64 QNN CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, Windows x64 QNN CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed

Copy link

Azure Pipelines successfully started running 9 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@ranjitshs
Copy link
Contributor Author

@snnn @tianleiwu
if no comments on this PR, can it get merge ? Please merge it.

@tianleiwu tianleiwu merged commit 82b2955 into microsoft:main Jul 27, 2024
65 of 67 checks passed
@ranjitshs ranjitshs deleted the ranjitshs/gtest-1.15.0-failure-fix branch July 28, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants