Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the HTP power setting #22227

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update the HTP power setting #22227

wants to merge 2 commits into from

Conversation

HectorSVC
Copy link
Contributor

Description

update the HTP power setting

@HectorSVC HectorSVC added the ep:QNN issues related to QNN exeution provider label Sep 26, 2024
rpc_control_latency_cfg.rpcControlLatencyConfig = rpc_control_latency;
rpc_polling_time.option = QNN_HTP_PERF_INFRASTRUCTURE_POWER_CONFIGOPTION_RPC_POLLING_TIME;
rpc_polling_time.rpcPollingTimeConfig = 9999;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's my understanding the polling change can only be supported by Android platform.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified it's supported on Windows

// only v69 or higher support rpc polling mode.
QnnHtpPerfInfrastructure_PowerConfig_t& rpc_polling_time_cfg = rpc_power_configs[1];
rpc_polling_time_cfg.option = QNN_HTP_PERF_INFRASTRUCTURE_POWER_CONFIGOPTION_RPC_POLLING_TIME;
if (rpc_polling_time > 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previous commit was setting to 9999 (max)
now we don't set anything (unless user provides)
Is that the desired default behavior? @chiwwang can you advise.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi George,
I think it's ok -- up to what you want to provide to users.
In some other implementations like TFLite Delegate, we bundled the rpc polling time into the performance profile, e.g., burst, HighPerformance... etc, so users have no chance to adjust the polling time.

But it's totally ok to make users decide this value, which gives users a finer grant cotrol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:QNN issues related to QNN exeution provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants