Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable codesign for maven packages #22308

Merged
merged 6 commits into from
Oct 4, 2024
Merged

Re-enable codesign for maven packages #22308

merged 6 commits into from
Oct 4, 2024

Conversation

snnn
Copy link
Member

@snnn snnn commented Oct 4, 2024

Description

PR #22217 was reverted. This PR re-enable it.

Motivation and Context

@snnn snnn marked this pull request as ready for review October 4, 2024 06:21
@snnn snnn requested a review from a team as a code owner October 4, 2024 06:21
@jchen351
Copy link
Contributor

jchen351 commented Oct 4, 2024

Can you rerun/fix the packaging pipeline?

@snnn
Copy link
Member Author

snnn commented Oct 4, 2024

Can you rerun/fix the packaging pipeline?

Would be no change. The pipeline is still broken due to a recent PR for adding multi LORA support.

@snnn snnn requested a review from jchen351 October 4, 2024 21:17
@snnn snnn merged commit 715b74d into main Oct 4, 2024
222 of 240 checks passed
@snnn snnn deleted the snnn/npm branch October 4, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants