Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto regenerate LORA's fbs files #22313

Merged
merged 8 commits into from
Oct 4, 2024
Merged

Auto regenerate LORA's fbs files #22313

merged 8 commits into from
Oct 4, 2024

Conversation

snnn
Copy link
Member

@snnn snnn commented Oct 4, 2024

Description

A left-over of PR #22046

Motivation and Context

@snnn snnn requested a review from a team as a code owner October 4, 2024 05:32
@snnn
Copy link
Member Author

snnn commented Oct 4, 2024

@luncliff , do you know why now we cannot download google benchmark's source code from vcpkg?

@snnn
Copy link
Member Author

snnn commented Oct 4, 2024

I think it is because of a regression in vcpkg-tool. See: microsoft/vcpkg#41199 (comment) and microsoft/vcpkg-tool#1501
We are using the 09-18 version of vcpkg-tool.

@luncliff
Copy link
Contributor

luncliff commented Oct 4, 2024 •
edited
Loading

@luncliff , do you know why now we cannot download google benchmark's source code from vcpkg?

No. I haven't met the message for several months. I will check the detail as soon as possible.

@snnn
Copy link
Member Author

snnn commented Oct 4, 2024

Recently vcpkg had a regression. Though the problem has been fixed, we are still using an unpatched one.

@snnn
Copy link
Member Author

snnn commented Oct 4, 2024

Now it works. Thanks for the quick response.

luncliff
luncliff reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@luncliff luncliff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. For future reference, we can specify vcpkg commit like this.
https://github.com/microsoft/vcpkg/releases/tag/2024.09.30

.github/workflows/windows.yml Show resolved Hide resolved
@snnn snnn merged commit f25f386 into main Oct 4, 2024
87 checks passed
@snnn snnn deleted the snnn-patch-8 branch October 4, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luncliff luncliff luncliff left review comments

@edgchen1 edgchen1 edgchen1 approved these changes

@jchen351 jchen351 jchen351 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snnn @luncliff @edgchen1 @jchen351