Initial WebGPU EP checkin #22318
Open
Initial WebGPU EP checkin #22318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs-eire
requested review from
snnn,
pranavsharma,
guschmue,
satyajandhyala,
prathikr and
skottmckay
snnn
reviewed
Oct 4, 2024
skottmckay
reviewed
Oct 4, 2024
tools/ci_build/github/apple/default_full_apple_framework_build_settings.json
Outdated
Show resolved
Hide resolved
tools/ci_build/github/apple/default_full_ios_framework_build_settings.json
Outdated
Show resolved
Hide resolved
tools/ci_build/github/apple/default_full_ios_framework_build_settings.json
Outdated
Show resolved
Hide resolved
tools/ci_build/github/azure-pipelines/templates/mac-cpu-packing-jobs.yml
Outdated
Show resolved
Hide resolved
fs-eire
force-pushed
the
fs-eire/webgpu-ep-first-checkin
branch
from
6d7bb5b
to
4ef2b61
Compare
fs-eire
force-pushed
the
fs-eire/webgpu-ep-first-checkin
branch
from
5ab391b
to
5346b07
Compare
skottmckay
approved these changes
Oct 6, 2024
| } else if (provider_name_ == onnxruntime::kWebGpuExecutionProvider) { | ||
| #ifdef USE_WEBGPU | ||
| session_options.AppendExecutionProvider( | ||
| "WebGPU", {{"intra_op_num_threads", std::to_string(performance_test_config.run_config.intra_op_num_threads)}}); |
There was a problem hiding this comment.
Out of interest why is this specified separately for WebGPU vs passing through and using the SessionOptions value (which is what we do with the xnnpack EP)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces the WebGPU EP into ONNX Runtime.
To make the PR as simple as possible, this PR excluded the following:
This PR now contains only 43 file changes (while the working branch contains 130+) and hopefully this makes it easier to review.
There is going to be separated PRs for each mentioned above.
Current working branch: #21904