Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework memcpy transformer to support WebGPU EP being added #22329

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Rework memcpy transformer to support WebGPU EP being added #22329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1c59fe6
Simplify.
skottmckay Oct 5, 2024
dab9327
Cleanups
skottmckay Oct 5, 2024
7593b3c
Ignore unassigned nodes
skottmckay Oct 6, 2024
52464bb
Fix unnecessary copy
skottmckay Oct 6, 2024
4cec815
Fix linux build warning
skottmckay Oct 6, 2024
ed17383
Fix condition
skottmckay Oct 6, 2024
626d191
Cleanup
skottmckay Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions include/onnxruntime/core/common/const_pointer_container.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@ class ConstPointerContainer {
ConstIterator(const ConstIterator& other) = default;
ConstIterator& operator=(const ConstIterator& other) = default;

bool operator==(const ConstIterator& other) const noexcept { return current_ == other.current_; }
bool operator!=(const ConstIterator& other) const noexcept { return current_ != other.current_; }
bool operator==(const ConstIterator& rhs) const noexcept { return current_ == rhs.current_; }
bool operator!=(const ConstIterator& rhs) const noexcept { return current_ != rhs.current_; }
size_t operator-(const ConstIterator& rhs) const noexcept { return current_ - rhs.current_; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be ptrdiff_t?


ConstIterator& operator++() {
++current_;
Expand Down
Loading
Loading