Skip to content

Commit

Permalink
chore(stderr): fix handling without stderr fileno (#402)
Browse files Browse the repository at this point in the history
  • Loading branch information
mxschmitt authored Dec 26, 2020
1 parent 63db2cf commit 3b87bca
Showing 1 changed file with 16 additions and 2 deletions.
18 changes: 16 additions & 2 deletions playwright/_transport.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,25 @@
# limitations under the License.

import asyncio
import io
import json
import os
import sys
from pathlib import Path
from typing import Dict
from typing import Dict, Optional


# Sourced from: https://github.com/pytest-dev/pytest/blob/da01ee0a4bb0af780167ecd228ab3ad249511302/src/_pytest/faulthandler.py#L69-L77
def _get_stderr_fileno() -> Optional[int]:
try:
return sys.stderr.fileno()
except (AttributeError, io.UnsupportedOperation):
# pytest-xdist monkeypatches sys.stderr with an object that is not an actual file.
# https://docs.python.org/3/library/faulthandler.html#issue-with-file-descriptors
# This is potentially dangerous, but the best we can do.
if not hasattr(sys, "__stderr__"):
return None
return sys.__stderr__.fileno()


class Transport:
Expand All @@ -41,7 +55,7 @@ async def run(self) -> None:
"run-driver",
stdin=asyncio.subprocess.PIPE,
stdout=asyncio.subprocess.PIPE,
stderr=sys.stderr,
stderr=_get_stderr_fileno(),
limit=32768,
)
assert proc.stdout
Expand Down

0 comments on commit 3b87bca

Please sign in to comment.