feat(html): link from attachment step to attachment #33267
Conversation
This comment has been minimized.
This comment has been minimized.
|
demo: Screen.Recording.2024-10-24.at.14.40.25.mov |
This comment has been minimized.
This comment has been minimized.
| <span style={{ float: 'right' }}>{msToString(step.duration)}</span> | ||
| {attachmentName && <a style={{ float: 'right' }} title='link to attachment' href={'#' + componentID(params => params.set('attachment', attachmentName))} onClick={(evt) => { evt.stopPropagation(); }}>{icons.attachment()}</a>} |
There was a problem hiding this comment.
Does this rely on the browser to automatically scroll to the anchor? How does that work together with the router? I am confused.
There was a problem hiding this comment.
Yes, that's how it works. Didn't even know we had a router until now - i'll see if I can switch this to our Link component.
I figured using the anchor to target an element is the most browser-standards way of making this work. But I can also change it to use scrollIntoView if you'd prefer that.
There was a problem hiding this comment.
#33295 is a refactoring that allows us to use one scrollIntoView implementation for all attachments. It makes this implementation a lot easier.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I've updated this PR to use the |
Test results for "tests 1"10 failed 3 flaky36950 passed, 650 skipped Merge workflow run. |
|
sorry, i'll need to look more into this to make links to |
Similar to #33265. Adds a link from the attachment step to the attachment view.