Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix react attribute casing in TestErrorView #33633

Merged
merged 1 commit into from
Nov 15, 2024
Merged

chore: fix react attribute casing in TestErrorView #33633

merged 1 commit into from
Nov 15, 2024

Conversation

mxschmitt
Copy link
Member

This fixes:

React does not recognize the data-testId prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase data-testid instead. If you accidentally passed it from a parent component, remove it from the DOM element.

@mxschmitt mxschmitt merged commit b91f609 into microsoft:main Nov 15, 2024
28 of 29 checks passed
@mxschmitt mxschmitt deleted the remove-unused-TestErrorView branch November 15, 2024 21:25
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

36901 passed, 650 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yury-s yury-s yury-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxschmitt @yury-s