fix(sw): fix UI mode on codespaces by not passing server
#33664
Merged
+9
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Skn0tt
changed the title
server as relative pathserver
Skn0tt
commented
Nov 19, 2024
| const guid = searchParams.get('ws'); | ||
| const wsURL = new URL(`../${guid}`, window.location.toString()); | ||
| wsURL.protocol = (window.location.protocol === 'https:' ? 'wss:' : 'ws:'); | ||
| let testServerBaseUrl = new URL('../', window.location.href); |
There was a problem hiding this comment.
window.location.href is something like https://localhost:1234/tracing/uiMode.html, and this expression turns that into https://localhost:1234/. If it was served deeper, like under https://localhost:1234/azdo-subdir/tracing/uiMode.html, then it'd turn into https://localhost:1234/azdo-subdor/.
This comment has been minimized.
This comment has been minimized.
|
@dgozman i've applied the changes we talked about. |
dgozman
approved these changes
Nov 19, 2024
Test results for "tests 1"1 flaky36952 passed, 650 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday we found that UI mode is broken on codespaces b/c the new
serverparameter points tolocalhost, which isn't available when the UI is accessed over Codespace's port forwarding host.This PR fixes that by making the
serverparameter only used in HMR mode. I'm also making the web server connection respect theserverparam in this PR.I've developed this on a Codespace and verified that it works.