Prevent ingestion failure on empty tables #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarah-widder
approved these changes
Aug 5, 2024
nikhilnagaraj
pushed a commit
to Admin-bh-Edge/Edge-Comp-Policies
that referenced
this pull request
Oct 2, 2024
Co-authored-by: Vikram Duvvur <vikramduvvur@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This address the bug mentioned in #1034 where the data preparation script fails when the table is empty.
Description
All this PR does is add a check to make sure there is a "span" of the text that each table corresponds to. If there is no such span, then it skips the table since that means it's just an empty table with no information.
Contribution Checklist