Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux component license/author info in SBOM #476

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

sebasgomez238
Copy link
Contributor

Takes advantage of the changes in microsoft/component-detection#934 that provides us with supplier and license information for LinuxComponents.

This PR also includes a cleanup of our ServiceCollectionExtensions to rely on the AddComponentDetection() method rather than setting up everything manually.

Similar changes will be required for: microsoft/component-detection#938 and microsoft/component-detection#940 but these are pending deployment/approval

@sebasgomez238 sebasgomez238 requested a review from a team as a code owner January 10, 2024 18:47
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (d251a5f) 59.78% compared to head (353f6e9) 59.73%.

Files Patch % Lines
...ers/ComponentDetection/LinuxComponentExtensions.cs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
- Coverage   59.78%   59.73%   -0.05%     
==========================================
  Files         248      248              
  Lines        7566     7572       +6     
  Branches      901      901              
==========================================
  Hits         4523     4523              
- Misses       2631     2637       +6     
  Partials      412      412              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebasgomez238 sebasgomez238 merged commit 7312f0c into main Jan 23, 2024
6 checks passed
@sebasgomez238 sebasgomez238 deleted the users/segomez/linux-component-supplier-info branch January 23, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants