-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Azure Pipelines pool #150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a readme explaining how to setup the pipeline, there is a doc directory for this:
how to create a pool
how to link it in azure devops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we now remove the GitHub action to run virtual tests, that we recently added? The full build should now cover everything and it seems repetitive to keep both just for reducing dependency on Azure.
Those are msft internal instructions while Azure Pipelines is an App already installed at Organization level (https://github.com/apps/azure-pipelines) |
Makes sense to me. Thoughts @ivarprudnikov ? |
I would not remove Github action just yet as it is quite fast and acts as a
fallback in a case azure pipeline gets removed or similar.
…On Tue 5 Sep 2023 at 12:51, Vincenzo Mauro ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/test_load.py
<#150 (comment)>
:
> @@ -11,7 +11,7 @@
from pyscitt.client import Client
NUM_CLAIMS = 100
-LOCUST_PEAK_USERS = 500
+LOCUST_PEAK_USERS = 100
LOCUST_USERS_SPAWN_RATE = 10
Thanks, decreased to 5
—
Reply to this email directly, view it on GitHub
<#150 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIA7YTG6XSUMZFUWQI7RJ3XY4G23ANCNFSM6AAAAAA4LT3QBA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Those are msft internal instructions while Azure Pipelines is an App already installed at Organization level (https://github.com/apps/azure-pipelines)
I have set up a new agent pool to be used by Azure Pipelines since the old one was removed.
This PR makes use of the new pool and restores the LOCUST_PEAK_USERS to 100 which is the original value while we investigate why 500 fails in SGX with no prefix tree.