Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

did:x509 issuer support in IETF profile #206

Merged
merged 31 commits into from
Aug 8, 2024
Merged

Conversation

achamayou
Copy link
Member

@achamayou achamayou commented Aug 6, 2024

Extension of the changes in #203 to authenticate did:x509 issuers, and updated sample illustrating the policy we expect to see in cases where they are used.

I chose to do this under the IETF profile, rather than x509, but the verification sequence is different from both existing profiles (IETF is only did:web at the moment, as far as I can tell):

  1. Find signing key (phdr.x5chain[0] currently, but eventually uhdr.x5chain[0] if digest(uhdr.x5chain[0]) == phdr.x5t)
  2. Verify COSE signature
  3. Check issuer is did:x509, resolve it against phdr.x5chain[0]
  4. Check resolved key matches phdr.x5chain[0]

app/src/main.cpp Outdated Show resolved Hide resolved
app/src/verifier.h Outdated Show resolved Hide resolved
app/src/verifier.h Outdated Show resolved Hide resolved
app/src/verifier.h Outdated Show resolved Hide resolved
app/src/verifier.h Outdated Show resolved Hide resolved
@achamayou achamayou changed the title [Draft] did:x509 issuer support did:x509 issuer support in IETF profile Aug 7, 2024
@achamayou achamayou marked this pull request as ready for review August 7, 2024 18:01
Copy link
Member

@ivarprudnikov ivarprudnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have identified a couple of possible improvements in the future but as it is the feature is ready to be released the further validated/assessed once deployed. Related issues were created to address some challenges.

@achamayou
Copy link
Member Author

For reference: #207 #208 and microsoft/didx509cpp#16

@achamayou achamayou merged commit 7653085 into microsoft:main Aug 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants