Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #631 #633

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Fix #631 #633

merged 3 commits into from
Sep 14, 2023

Conversation

Naville
Copy link
Contributor

@Naville Naville commented Sep 14, 2023

Add wrapper override for the Windows variant of maloc_usable_size : _msize

@Naville
Fix #631
ab412ca 
Add wrapper override for the Windows variant of maloc_usable_size : _msize
mjp41
mjp41 requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@mjp41 mjp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. Sorry I have been swamped by another project so didn't have time to replicate your issue.

src/snmalloc/override/malloc.cc Outdated Show resolved Hide resolved
@Naville @mjp41
Update src/snmalloc/override/malloc.cc
f873e11 
Co-authored-by: Matthew Parkinson <mjp41@users.noreply.github.com>
@Naville
Copy link
Contributor Author

Naville commented Sep 14, 2023

Done

@mjp41 mjp41 enabled auto-merge (squash) September 14, 2023 10:51
@mjp41 mjp41 merged commit 6b8f333 into microsoft:main Sep 14, 2023
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjp41 mjp41 mjp41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Naville @mjp41